[PATCH wayland 1/2] text-backend: remove the weston_seat destruction listener on destroy

Rob Bradford robert.bradford at intel.com
Tue Jul 30 02:48:29 PDT 2013


On 30 July 2013 00:41, Kristian Høgsberg <hoegsberg at gmail.com> wrote:
> On Wed, Jul 24, 2013 at 04:57:32PM +0100, Rob Bradford wrote:
>> From: Rob Bradford <rob at linux.intel.com>
>>
>> Prior to freeing the memory in which the link node for the signal is
>> emedded we should remove the link node from the list to prevent the list
>> from being corrupted.
>>
>> https://bugs.freedesktop.org/show_bug.cgi?id=67231
>
> This and 2/2 look good, and I've applied them.  It wasn't clear from
> the bug that this was enough though, it sounds like there's still some
> linked list corruption in there.  Good catches here though.


Yes...it's a bit of a game of whack-a-mole :-) The first fix exposed
the second. I can't reproduce the remaining valgrind error in the bug
but I understand where it's coming from and will try and look into it
further.

Rob


More information about the wayland-devel mailing list