[PATCH] configure.ac: Do not make missing colord or libunwind a hard failure

Daniel Stone daniel at fooishbar.org
Mon Jun 3 11:45:47 PDT 2013


Hi,

On 3 June 2013 19:41, Ossama Othman <ossama.othman at intel.com> wrote:
> -AM_CONDITIONAL(ENABLE_COLORD,
> -              test "x$enable_colord" = "xyes")
>  if test x$enable_colord = xyes; then
> -  PKG_CHECK_MODULES(COLORD, colord >= 0.1.27)
> +  PKG_CHECK_MODULES([COLORD],
> +                    [colord >= 0.1.27],
> +                   [],
> +                   [enable_colord=no
> +                     AC_MSG_WARN([Colord support won't be enabled.  Desired version not found.])])

The usual pattern here is to set the default to 'auto', which will
check whether or not the dependency is installed and select yes or no
accordingly.  If someone explicitly passes --enable-colord and it's
not installed, we want the configure run to fail, rather than doing
something other than what they told us to.

Cheers,
Daniel


More information about the wayland-devel mailing list