[PATCH 2/2] compositor-drm: Force DPMS state to ON after drmModeSetCrtc()

Daniel Vetter daniel at ffwll.ch
Thu Jun 6 12:30:38 PDT 2013


On Tue, Jun 04, 2013 at 04:24:05PM +0300, Ander Conselvan de Oliveira wrote:
> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> 
> The kernel is supposed to set this when drmModeSetCrtc() is called but
> at least the i915 driver wouldn't do that in all cases. A fix for this
> should be released with kernel 3.10, but we work around the issue in
> older kernels by always forcing DPMS to ON when doing a mode set.
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=64873

Iirc drivers still based on the drm crtc helper framework in the kernel
can also be tricked into not consistently enabling outputs ...
-Daniel

> ---
>  src/compositor-drm.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/compositor-drm.c b/src/compositor-drm.c
> index 27d4d02..45aa61f 100644
> --- a/src/compositor-drm.c
> +++ b/src/compositor-drm.c
> @@ -588,6 +588,7 @@ drm_output_repaint(struct weston_output *output_base,
>  			weston_log("set mode failed: %m\n");
>  			return;
>  		}
> +		output_base->set_dpms(output_base, WESTON_DPMS_ON);
>  	}
>  
>  	if (drmModePageFlip(compositor->drm.fd, output->crtc_id,
> -- 
> 1.7.9.5
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch


More information about the wayland-devel mailing list