[PATCH weston 1/3] gl-renderer: Track the buffer type in gl_surface_state

[Giulio Camuffo]

This also fixes the attach of a valid buffer after attaching a NULL one.
Currently the surface is showing the wrong buffer.


2013/6/11 Pekka Paalanen <ppaalanen at gmail.com>

> On Fri,  7 Jun 2013 16:52:44 +0300
> Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
> wrote:
>
> > Checking for gs->num_images for determining the previous buffer type
> > when attaching is not reliable. The number of images is never cleared
> > in the SHM path, so after a switch from an EGL buffer to SHM, every
> > following attach of an SHM buffer will happen with gs->num_images > 0,
> > and the code will assume the previous buffer was an EGL one.
> >
> > Fix this by adding a buffer_type field to gl_surface_state.
> > ---
> >  src/gl-renderer.c |   21 +++++++++++++++++----
> >  1 file changed, 17 insertions(+), 4 deletions(-)
>
> I like tracking buffer type explicitly, rather than inferring from
> num_images.
>
> This series looks ok and seems to work ok from what little testing I
> did.
>
>
> Thanks,
> pq
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130620/4c554903/attachment.html>