[PATCH weston 2/7] autotools: Define paths in configure.ac

Quentin Glidic sardemff7+wayland at sardemff7.net
Thu Jun 20 21:51:09 PDT 2013

On 20/06/2013 21:09, Kristian Høgsberg wrote:
> On Tue, Jun 18, 2013 at 09:11:29AM +0200, Quentin Glidic wrote:
>> -pkgconfigdir = $(libdir)/pkgconfig
>>   pkgconfig_DATA = weston.pc
> I'm not sure we want this, it's convention to define the *dir variable
> in the Makefile.am along with the dependent varialbles...

In this case, pkgconfigdir is better defined by the PKG_INSTALLDIR 
macro, because it could change depending on the system configuration.

>> -moduledir = @libdir@/weston
>>   module_LTLIBRARIES = xwayland.la
> ... I certainly find it confusion to find module_LTLIBRARIES in the
> Makefile.am and not have the moduledir definition nearby.

In this case, Weston is the one able to define these dirs. But what 
about external modules? They have to rely on a blind guess if we do not 
tell them the correct value ourselves.

We can provide the value in weston.pc while still defining it in 
Makefile.am, but in the current layout, we then have many places to get 
it wrong if we want to change it.

(The same goes for pkglibexec, I should probably change it to 
internalclientsdir or something like that.)

The point of this patch is to define Weston dirs in a central location 
to use them everywhere. This way, it is easier to provide directly the 
correct values in weston.pc (see the corresponding patch which provides 
moduledir in weston.pc).

Thanks for reviewing,


Quentin “Sardem FF7” Glidic

More information about the wayland-devel mailing list