[PATCH weston v2 2/3] input: Add support for making libxkbcommon optional
Rob Bradford
robert.bradford at intel.com
Fri Jun 21 10:19:44 PDT 2013
From: Matt Roper <matthew.d.roper at intel.com>
In embedded environments, devices that appear as evdev "keyboards" often
have no resemblence to PC-style keyboards. It is not uncommon for such
environments to have no concept of modifier keys and no need for XKB key
mapping; in these cases libxkbcommon initialization becomes unnecessary
startup overhead. On some SOC platforms, xkb keymap compilation can
account for as much as 1/3 - 1/2 of the total compositor startup time.
This patch introduces a 'use_xkbcommon' flag in the core compositor
structure that indicates whether the compositor is running in "raw
keyboard" mode. In raw keyboard mode, the compositor bypasses all
libxkbcommon initialization and processing. 'key' events containing the
integer keycode will continue to be delivered via the wl_keyboard
interface, but no 'keymap' event will be sent to clients. No modifier
handling or keysym mapping is performed in this mode.
Note that upstream sample apps (e.g., weston-terminal or the
desktop-shell client) will not recognize raw keycodes and will not react
to keypresses when the compositor is operating in raw keyboard mode.
This is expected behavior; key events are still being sent to the
client, the client (and/or its toolkit) just isn't written to handle
keypresses without doing xkb keysym mapping. Applications written
specifically for such embedded environments would be handling keypresses
via the raw keycode delivered as part of the 'key' event rather than
using xkb keysym mapping.
Whether to use xkbcommon is a global option that applies to all
compositor keyboard devices on the system; it is an all-or-nothing flag.
This patch simply adds conditional checks on whether xkbcommon is to be
used or not.
v3 don't send zero as the file descriptor - instead send the result of
opening /dev/null
v2 by Rob Bradford <rob at linux.intel.com>: the original version of the
patch used a "raw_keycodes" flag instead of the "use_xkbcommon" used in
this patch.
v1: Reviewed-by: Singh, Satyeshwar <satyeshwar.singh at intel.com>
v1: Reviewed-by: Bob Paauwe <bob.j.paauwe at intel.com>
---
src/compositor.c | 1 +
src/compositor.h | 3 +++
src/input.c | 74 ++++++++++++++++++++++++++++++++++++++++----------------
3 files changed, 57 insertions(+), 21 deletions(-)
diff --git a/src/compositor.c b/src/compositor.c
index 5c82413..c9ee67b 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -2795,6 +2795,7 @@ weston_compositor_init(struct weston_compositor *ec,
weston_plane_init(&ec->primary_plane, 0, 0);
weston_compositor_stack_plane(ec, &ec->primary_plane, NULL);
+ ec->use_xkbcommon = 1;
s = weston_config_get_section(ec->config, "keyboard", NULL, NULL);
weston_config_section_get_string(s, "keymap_rules",
(char **) &xkb_names.rules, NULL);
diff --git a/src/compositor.h b/src/compositor.h
index 297f971..9fa31e5 100644
--- a/src/compositor.h
+++ b/src/compositor.h
@@ -572,6 +572,9 @@ struct weston_compositor {
struct xkb_rule_names xkb_names;
struct xkb_context *xkb_context;
struct weston_xkb_info xkb_info;
+
+ /* Raw keyboard processing (no libxkbcommon initialization or handling) */
+ int use_xkbcommon;
};
struct weston_buffer_reference {
diff --git a/src/input.c b/src/input.c
index ad4512d..9eb980a 100644
--- a/src/input.c
+++ b/src/input.c
@@ -26,6 +26,7 @@
#include <sys/mman.h>
#include <assert.h>
#include <unistd.h>
+#include <fcntl.h>
#include "../shared/os-compatibility.h"
#include "compositor.h"
@@ -813,6 +814,10 @@ update_modifier_state(struct weston_seat *seat, uint32_t serial, uint32_t key,
{
enum xkb_key_direction direction;
+ /* Keyboard modifiers don't exist in raw keyboard mode */
+ if (!seat->compositor->use_xkbcommon)
+ return;
+
if (state == WL_KEYBOARD_KEY_STATE_PRESSED)
direction = XKB_KEY_DOWN;
else
@@ -1202,9 +1207,17 @@ seat_get_keyboard(struct wl_client *client, struct wl_resource *resource,
wl_list_insert(&seat->keyboard->resource_list, wl_resource_get_link(cr));
wl_resource_set_destructor(cr, unbind_resource);
- wl_keyboard_send_keymap(cr, WL_KEYBOARD_KEYMAP_FORMAT_XKB_V1,
- seat->xkb_info.keymap_fd,
- seat->xkb_info.keymap_size);
+ if (seat->compositor->use_xkbcommon) {
+ wl_keyboard_send_keymap(cr, WL_KEYBOARD_KEYMAP_FORMAT_XKB_V1,
+ seat->xkb_info.keymap_fd,
+ seat->xkb_info.keymap_size);
+ } else {
+ int null_fd = open("/dev/null", O_RDONLY);
+ wl_keyboard_send_keymap(cr, WL_KEYBOARD_KEYMAP_FORMAT_NO_KEYMAP,
+ null_fd,
+ 0);
+ close(null_fd);
+ }
if (seat->keyboard->focus &&
wl_resource_get_client(seat->keyboard->focus->resource) == client) {
@@ -1263,6 +1276,13 @@ int
weston_compositor_xkb_init(struct weston_compositor *ec,
struct xkb_rule_names *names)
{
+ /*
+ * If we're operating in raw keyboard mode, libxkbcommon isn't used and
+ * shouldn't be initialized.
+ */
+ if (!ec->use_xkbcommon)
+ return 0;
+
if (ec->xkb_context == NULL) {
ec->xkb_context = xkb_context_new(0);
if (ec->xkb_context == NULL) {
@@ -1297,6 +1317,13 @@ static void xkb_info_destroy(struct weston_xkb_info *xkb_info)
void
weston_compositor_xkb_destroy(struct weston_compositor *ec)
{
+ /*
+ * If we're operating in raw keyboard mode, we never initialized
+ * libxkbcommon so there's no cleanup to do either.
+ */
+ if (!ec->use_xkbcommon)
+ return;
+
free((char *) ec->xkb_names.rules);
free((char *) ec->xkb_names.model);
free((char *) ec->xkb_names.layout);
@@ -1401,25 +1428,28 @@ weston_seat_init_keyboard(struct weston_seat *seat, struct xkb_keymap *keymap)
if (seat->keyboard)
return 0;
- if (keymap != NULL) {
- seat->xkb_info.keymap = xkb_map_ref(keymap);
- if (weston_xkb_info_new_keymap(&seat->xkb_info) < 0)
- return -1;
- } else {
- if (weston_compositor_build_global_keymap(seat->compositor) < 0)
+
+ if (seat->compositor->use_xkbcommon) {
+ if (keymap != NULL) {
+ seat->xkb_info.keymap = xkb_map_ref(keymap);
+ if (weston_xkb_info_new_keymap(&seat->xkb_info) < 0)
+ return -1;
+ } else {
+ if (weston_compositor_build_global_keymap(seat->compositor) < 0)
+ return -1;
+ seat->xkb_info = seat->compositor->xkb_info;
+ seat->xkb_info.keymap = xkb_map_ref(seat->xkb_info.keymap);
+ }
+
+ seat->xkb_state.state = xkb_state_new(seat->xkb_info.keymap);
+ if (seat->xkb_state.state == NULL) {
+ weston_log("failed to initialise XKB state\n");
return -1;
- seat->xkb_info = seat->compositor->xkb_info;
- seat->xkb_info.keymap = xkb_map_ref(seat->xkb_info.keymap);
- }
+ }
- seat->xkb_state.state = xkb_state_new(seat->xkb_info.keymap);
- if (seat->xkb_state.state == NULL) {
- weston_log("failed to initialise XKB state\n");
- return -1;
+ seat->xkb_state.leds = 0;
}
- seat->xkb_state.leds = 0;
-
keyboard = weston_keyboard_create();
if (keyboard == NULL) {
weston_log("failed to allocate weston keyboard struct\n");
@@ -1503,9 +1533,11 @@ weston_seat_release(struct weston_seat *seat)
wl_list_remove(&seat->link);
/* The global object is destroyed at wl_display_destroy() time. */
- if (seat->xkb_state.state != NULL)
- xkb_state_unref(seat->xkb_state.state);
- xkb_info_destroy(&seat->xkb_info);
+ if (seat->compositor->use_xkbcommon) {
+ if (seat->xkb_state.state != NULL)
+ xkb_state_unref(seat->xkb_state.state);
+ xkb_info_destroy(&seat->xkb_info);
+ }
if (seat->pointer)
weston_pointer_destroy(seat->pointer);
--
1.8.2.1
More information about the wayland-devel
mailing list