[PATCH weston 1/7] weston.pc: Add dependencies for pixman-1 and xkbcommon

[Kristian Høgsberg]

On Fri, Jun 21, 2013 at 06:43:36AM +0200, Quentin Glidic wrote:
> On 20/06/2013 21:05, Kristian Høgsberg wrote:
> >On Tue, Jun 18, 2013 at 09:11:28AM +0200, Quentin Glidic wrote:
> >>From: Quentin Glidic <sardemff7+git at sardemff7.net>
> >>
> >>Weston headers include pixman and libxkbcommon headers
> >>
> >>Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
> >>---
> >>  src/weston.pc.in | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >>diff --git a/src/weston.pc.in b/src/weston.pc.in
> >>index 828cb1f..7a09938 100644
> >>--- a/src/weston.pc.in
> >>+++ b/src/weston.pc.in
> >>@@ -8,4 +8,5 @@ pkglibexecdir=${libexecdir}/@PACKAGE@
> >>  Name: Weston Plugin API
> >>  Description: Header files for Weston plugin development
> >>  Version: @WESTON_VERSION@
> >>+Requires.private: pixman-1 xkbcommon
> >
> >Oh, right we need that... but shouldn't it just be plain Requires:?
> >If an external header file is part of the API, we need an explicit
> >Requires:
> 
> That was the case in the first version of the patch. However, a
> client can use Weston without using pixman or xkbcommon (that’s the
> case for my notifications plugin, for example).
> If the plugin needs them, it should definitely link to them explicitly.
> If it does not, we want to avoid the plugin linking to them.

But it doesn't matter whether or not the client uses pixman, it still
needs the right cflags to make the #include <pixman.h> in compositor.h
not break.

Kristian

> >>  Cflags: -I${includedir}
> >>--
> >>1.8.3
> 
> -- 
> 
> Quentin “Sardem FF7” Glidic