[PATCH libxkbcommon v2] keymap: add xkb_keymap_new_from_buffer()
David Herrmann
dh.herrmann at gmail.com
Wed Mar 27 15:39:58 PDT 2013
The current API doesn't allow the caller to create keymaps from mmap()'ed
files. The problem is, xkb_keymap_new_from_string() requires a terminating
0 byte. However, there is no way to guarantee that when using mmap() so a
user currently has to copy the whole file just to get the terminating zero
byte (assuming they cannot use xkb_keymap_new_from_file()).
This adds a new entry xkb_keymap_new_from_buffer() which takes a memory
location and the buffer size in bytes.
Internally, we depend on yy_scan_{string,byte}() helpers. According to
flex documentation these already copy the input string because they are
wrappers around yy_scan_buffer().
yy_scan_buffer() on the other hand has some insane requirements. The
buffer must be writeable and the last two bytes must be ASCII-NUL. But the
buffer may contain other 0 bytes just fine.
Because we don't want these constraints in our public API,
xkb_keymap_new_from_buffer() needs to create a copy of the input memory.
But it then calls yy_scan_buffer() directly. Hence, we have the same
number of buffer-copies as with *_from_string() but without the
terminating 0 requirement.
The explicit yy_scan_buffer() call is preferred over yy_scan_byte() so the
buffer-copy operation is not hidden somewhere in flex.
Maybe some day we no longer depend on flex and can have a zero-copy API. A
user could mmap() a file and it would get parsed right from this buffer.
But until then, we shouldn't expose this limitation in the API but instead
provide an API that some day can work with zero-copy.
Signed-off-by: David Herrmann <dh.herrmann at gmail.com>
---
Makefile.am | 2 ++
src/xkbcomp/scanner.l | 32 +++++++++++++++++
src/xkbcomp/xkbcomp-priv.h | 4 +++
src/xkbcomp/xkbcomp.c | 45 +++++++++++++++++++++++
test/.gitignore | 1 +
test/buffercomp.c | 90 ++++++++++++++++++++++++++++++++++++++++++++++
test/common.c | 15 ++++++++
test/test.h | 3 ++
xkbcommon/xkbcommon.h | 14 ++++++++
9 files changed, 206 insertions(+)
create mode 100644 test/buffercomp.c
diff --git a/Makefile.am b/Makefile.am
index 6ecb8f5..3cb4219 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -140,6 +140,7 @@ TESTS = \
test/context \
test/rules-file \
test/stringcomp \
+ test/buffercomp \
test/keyseq \
test/log
TESTS_LDADD = libtest.la
@@ -152,6 +153,7 @@ test_context_LDADD = $(TESTS_LDADD)
test_rules_file_CFLAGS = $(AM_CFLAGS) -Wno-declaration-after-statement
test_rules_file_LDADD = $(TESTS_LDADD) -lrt
test_stringcomp_LDADD = $(TESTS_LDADD)
+test_buffercomp_LDADD = $(TESTS_LDADD)
test_keyseq_LDADD = $(TESTS_LDADD)
test_log_LDADD = $(TESTS_LDADD)
test_interactive_LDADD = $(TESTS_LDADD)
diff --git a/src/xkbcomp/scanner.l b/src/xkbcomp/scanner.l
index 5ccf3e9..f30462d 100644
--- a/src/xkbcomp/scanner.l
+++ b/src/xkbcomp/scanner.l
@@ -267,6 +267,38 @@ XkbParseString(struct xkb_context *ctx, const char *string,
return xkb_file;
}
+/*
+ * yy_scan_buffer() requires the last two bytes of \buf to be 0. These two bytes
+ * are not scanned. Other zero bytes in the buffer are scanned normally, though.
+ * Due to these terminating zeroes, \length must be greater than 2.
+ * Furthermore, the buffer must be writable and you cannot make any assumptions
+ * about it after the scanner finished.
+ * All this must be guaranteed by the caller of this function!
+ */
+XkbFile *
+XkbParseBuffer(struct xkb_context *ctx, char *buf, size_t length,
+ const char *file_name)
+{
+ yyscan_t scanner;
+ struct scanner_extra extra;
+ YY_BUFFER_STATE state;
+ XkbFile *xkb_file;
+
+ if (!init_scanner(&scanner, &extra, ctx, file_name))
+ return NULL;
+
+ xkb_file = NULL;
+ state = yy_scan_buffer(buf, length, scanner);
+ if (state) {
+ xkb_file = parse(ctx, scanner, NULL);
+ yy_delete_buffer(state, scanner);
+ }
+
+ clear_scanner(scanner);
+
+ return xkb_file;
+}
+
XkbFile *
XkbParseFile(struct xkb_context *ctx, FILE *file,
const char *file_name, const char *map)
diff --git a/src/xkbcomp/xkbcomp-priv.h b/src/xkbcomp/xkbcomp-priv.h
index b2b40fd..0d35255 100644
--- a/src/xkbcomp/xkbcomp-priv.h
+++ b/src/xkbcomp/xkbcomp-priv.h
@@ -45,6 +45,10 @@ XkbFile *
XkbParseString(struct xkb_context *ctx, const char *string,
const char *file_name);
+XkbFile *
+XkbParseBuffer(struct xkb_context *ctx, char *buf, size_t length,
+ const char *file_name);
+
void
FreeXkbFile(XkbFile *file);
diff --git a/src/xkbcomp/xkbcomp.c b/src/xkbcomp/xkbcomp.c
index 5025dc6..9bb2725 100644
--- a/src/xkbcomp/xkbcomp.c
+++ b/src/xkbcomp/xkbcomp.c
@@ -149,6 +149,51 @@ xkb_keymap_new_from_string(struct xkb_context *ctx,
}
XKB_EXPORT struct xkb_keymap *
+xkb_keymap_new_from_buffer(struct xkb_context *ctx,
+ const char *buffer,
+ size_t length,
+ enum xkb_keymap_format format,
+ enum xkb_keymap_compile_flags flags)
+{
+ XkbFile *file;
+ struct xkb_keymap *keymap;
+ char *buf;
+
+ if (format != XKB_KEYMAP_FORMAT_TEXT_V1) {
+ log_err(ctx, "Unsupported keymap format %d\n", format);
+ return NULL;
+ }
+
+ if (!buffer) {
+ log_err(ctx, "No buffer specified to generate XKB keymap\n");
+ return NULL;
+ }
+
+ buf = malloc(length + 2);
+ if (!buf) {
+ log_err(ctx, "Cannot allocate buffer for keymap\n");
+ return NULL;
+ }
+
+ /* yy_scan_buffer requires two terminating zero bytes */
+ memcpy(buf, buffer, length);
+ buf[length] = 0;
+ buf[length + 1] = 0;
+
+ file = XkbParseBuffer(ctx, buf, length + 2, "input");
+ if (!file) {
+ log_err(ctx, "Failed to parse input xkb file\n");
+ free(buf);
+ return NULL;
+ }
+
+ keymap = compile_keymap_file(ctx, file, format, flags);
+ FreeXkbFile(file);
+ free(buf);
+ return keymap;
+}
+
+XKB_EXPORT struct xkb_keymap *
xkb_keymap_new_from_file(struct xkb_context *ctx,
FILE *file,
enum xkb_keymap_format format,
diff --git a/test/.gitignore b/test/.gitignore
index 5a0b89f..d4bb051 100644
--- a/test/.gitignore
+++ b/test/.gitignore
@@ -7,6 +7,7 @@ state
context
rules-file
stringcomp
+buffercomp
keyseq
log
interactive
diff --git a/test/buffercomp.c b/test/buffercomp.c
new file mode 100644
index 0000000..96eb14b
--- /dev/null
+++ b/test/buffercomp.c
@@ -0,0 +1,90 @@
+/*
+ * Copyright © 2009 Dan Nicholson
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
+ * DEALINGS IN THE SOFTWARE.
+ */
+
+#include <assert.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#include "test.h"
+
+#define DATA_PATH "keymaps/stringcomp.data"
+
+int
+main(int argc, char *argv[])
+{
+ struct xkb_context *ctx = test_get_context();
+ struct xkb_keymap *keymap;
+ char *original, *dump;
+
+ assert(ctx);
+
+ /* Load in a prebuilt keymap, make sure we can compile it from memory,
+ * then compare it to make sure we get the same result when dumping it
+ * to a string. */
+ original = test_read_file(DATA_PATH);
+ assert(original);
+
+ keymap = test_compile_buffer(ctx, original, strlen(original));
+ assert(keymap);
+
+ dump = xkb_keymap_get_as_string(keymap, XKB_KEYMAP_USE_ORIGINAL_FORMAT);
+ assert(dump);
+
+ if (!streq(original, dump)) {
+ fprintf(stderr,
+ "round-trip test failed: dumped map differs from original\n");
+ fprintf(stderr, "path to original file: %s\n",
+ test_get_path(DATA_PATH));
+ fprintf(stderr, "length: dumped %lu, original %lu\n",
+ (unsigned long) strlen(dump),
+ (unsigned long) strlen(original));
+ fprintf(stderr, "dumped map:\n");
+ fprintf(stderr, "%s\n", dump);
+ fflush(stderr);
+ assert(0);
+ }
+
+ free(original);
+ free(dump);
+ xkb_keymap_unref(keymap);
+
+ /* Make sure we can't (falsely claim to) compile an empty string. */
+ keymap = test_compile_buffer(ctx, "", 0);
+ assert(!keymap);
+
+ /* Make sure we can recompile our output for a normal keymap from rules. */
+ keymap = test_compile_rules(ctx, NULL, NULL,
+ "ru,ca,de,us", ",multix,neo,intl", NULL);
+ assert(keymap);
+ dump = xkb_keymap_get_as_string(keymap, XKB_KEYMAP_USE_ORIGINAL_FORMAT);
+ assert(dump);
+ xkb_keymap_unref(keymap);
+ keymap = test_compile_buffer(ctx, dump, strlen(dump));
+ assert(keymap);
+ xkb_keymap_unref(keymap);
+ free(dump);
+
+ xkb_context_unref(ctx);
+
+ return 0;
+}
diff --git a/test/common.c b/test/common.c
index f960501..208bb56 100644
--- a/test/common.c
+++ b/test/common.c
@@ -147,6 +147,21 @@ test_compile_string(struct xkb_context *context, const char *string)
}
struct xkb_keymap *
+test_compile_buffer(struct xkb_context *context, const char *buf, size_t len)
+{
+ struct xkb_keymap *keymap;
+
+ keymap = xkb_keymap_new_from_buffer(context, buf, len,
+ XKB_KEYMAP_FORMAT_TEXT_V1, 0);
+ if (!keymap) {
+ fprintf(stderr, "Failed to compile keymap from memory buffer\n");
+ return NULL;
+ }
+
+ return keymap;
+}
+
+struct xkb_keymap *
test_compile_rules(struct xkb_context *context, const char *rules,
const char *model, const char *layout,
const char *variant, const char *options)
diff --git a/test/test.h b/test/test.h
index 046b64e..bf51c8f 100644
--- a/test/test.h
+++ b/test/test.h
@@ -46,6 +46,9 @@ struct xkb_keymap *
test_compile_string(struct xkb_context *context, const char *string);
struct xkb_keymap *
+test_compile_buffer(struct xkb_context *context, const char *buf, size_t len);
+
+struct xkb_keymap *
test_compile_rules(struct xkb_context *context, const char *rules,
const char *model, const char *layout, const char *variant,
const char *options);
diff --git a/xkbcommon/xkbcommon.h b/xkbcommon/xkbcommon.h
index 244b35b..4d40752 100644
--- a/xkbcommon/xkbcommon.h
+++ b/xkbcommon/xkbcommon.h
@@ -727,6 +727,20 @@ xkb_keymap_new_from_string(struct xkb_context *context, const char *string,
enum xkb_keymap_compile_flags flags);
/**
+ * Create a keymap from a memory buffer.
+ *
+ * This is just like xkb_keymap_new_from_string(), but takes a length argument
+ * so the input string does not have to be zero-terminated.
+ *
+ * @see xkb_keymap_new_from_string()
+ * @memberof xkb_keymap
+ */
+struct xkb_keymap *
+xkb_keymap_new_from_buffer(struct xkb_context *context, const char *buffer,
+ size_t length, enum xkb_keymap_format format,
+ enum xkb_keymap_compile_flags flags);
+
+/**
* Take a new reference on a keymap.
*
* @returns The passed in keymap.
--
1.8.2
More information about the wayland-devel
mailing list