[PATCH] RDP compositor take 5

[Hardening]

On 30/03/2013 21:34, Jason Ekstrand wrote:
> Hardening,
> This is looking really good.  I only have a couple comments on the
> code below that should take all of 5 minutes to address.
>
[...]
>> +       } else {
>> +               /* get the socket from RDP_FD var */
>> +               fd_str = getenv("RDP_FD");
>> +               if(!fd_str) {
>> +                       weston_log("RDP_FD env variable not set");
>> +                       goto err_output;
>> +               }
>> +
>> +               fd = strtoul(fd_str, NULL, 10);
>> +               if(rdp_peer_init(freerdp_peer_new(fd), c))
>> +                       goto err_output;
>> +       }
> 
> I'm curious what your use-case is for passing an FD to an RDP server.
> Do you intend it to have an authentication daemon that then starts RDP
> weston?
> 
In this case there's no listener. This could be used to have a process
that forks a virtual desktop (weston in this case) and wants to get the
display remotely using RDP.

I'm also preparing some patch for FreeRDP to have that kind of invocation:
xfreerdp "/fork:weston --backend=rdp-compositor --width=800 --height=600"

or with some code to take input/output from stdin/stdout:
xfreerdp /stdin | weston --backend=rdp-compositor --width=800
--height=600 --rdp-pipe

Hardening