[PATCH] Add initial color management framework code

[Richard Hughes]

On 3 May 2013 11:53, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> +     o->set_gamma(o, size, red, red, red);
> Three times red? :-)

Good catch, thanks.

>> +     p = calloc(sizeof(struct weston_color_profile), 1);
> Calloc arguments are swapped.

All fixed.

>> +     weston_cms_destroy_profile(output->color_profile);
> Was this call supposed to be replaced by an output destroy signal
> listener? IIRC there were some such comments before.

I think krh meant the cms plugin should listen for the devices being
created and destroyed. I think the color_profile structure is small
enough not to need the complexity of a callback, and I'm not sure we
want to teach profiles about devices if you see what I mean. It's
really not much different to calling any of the other functions that
deallocate per-output state. The CMS plugin implements all of the
signals we talked about.

New patch attached. Thanks for the review.

Richard
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-initial-color-management-framework-code.patch
Type: application/octet-stream
Size: 19306 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130503/b5a71def/attachment-0001.obj>