[PATCH weston] shell: Add a lock binding

Bill Spitzak spitzak at gmail.com
Tue May 14 13:23:09 PDT 2013



Kristian Høgsberg wrote:
> On Mon, May 13, 2013 at 11:49 PM, Bill Spitzak <spitzak at gmail.com> wrote:
>> Kristian Høgsberg wrote:
>>
>>> The problem then is that the key release of the binding will now count
>>> as activity and undo the lock.  I think we'll need a custom grab (see
>>> weston_compositor_run_key_binding()) that triggers the lock on release
>>> of the last key in the binding.  Or maybe add a "virtual modifier",
>>> say MODIFIER_RELEASE, to make the binding code trigger the binding on
>>> release instead.
>>
>> Could you just have all release events not count as "activity"?
> 
> Hmm, maybe... they way it works now is that pressing and holding a key
> (or button) inhibits the idle timer and when you then release we reset
> it.  I think the expected behavior is that if you hold down a button
> long enough for the idle time to expire, releasing the button doesn't
> immediately trigger the screensaver.  That's arguably a corner case of
> course, but I think that behavior is worth preserving.

That does sound better, but now I am confused as to what the problem is? 
It seems like it is already solved. Have exactly the same stuff that 
inhibits the idle timer also not "count as activity".


More information about the wayland-devel mailing list