[PATCH weston] weston-launch: Print explanation of why we failed to open the device

Kristian Høgsberg hoegsberg at gmail.com
Mon May 20 13:56:47 PDT 2013


On Mon, May 20, 2013 at 04:55:10PM +0100, Rob Bradford wrote:
> From: Rob Bradford <rob at linux.intel.com>

That's better, though I wonder if we should instead let weston log the
error message using weston_log()... committed this for now.

Kristian

> ---
>  src/weston-launch.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/src/weston-launch.c b/src/weston-launch.c
> index 89c3c5a..42b2506 100644
> --- a/src/weston-launch.c
> +++ b/src/weston-launch.c
> @@ -320,12 +320,17 @@ handle_open(struct weston_launch *wl, struct msghdr *msg, ssize_t len)
>  		goto err0;
>  
>  	fd = open(message->path, message->flags);
> -	if (fd < 0)
> +	if (fd < 0) {
> +		fprintf(stderr, "Error opening device %s: %m\n",
> +			message->path);
>  		goto err0;
> +	}
>  
>  	if (major(s.st_rdev) != INPUT_MAJOR) {
>  		close(fd);
>  		fd = -1;
> +		fprintf(stderr, "Device %s is not an input device\n",
> +			message->path);
>  		goto err0;
>  	}
>  
> -- 
> 1.8.1.4
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list