[PATCH weston 2/3] tests: allow weston test plugin to keep on running

Kristian Høgsberg hoegsberg at gmail.com
Thu Nov 21 21:45:13 PST 2013


On Thu, Nov 21, 2013 at 04:23:57PM +0200, ppaalanen at gmail.com wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> If the environment variable WESTON_TEST_CLIENT_PATH is not set, do not
> quit Weston in the test plugin.
> 
> This allows one to start Weston with the test plugin manually, and then
> run any tests also manually, while observing Weston's behaviour over
> time. This is useful for:
> - Running a test multiple times and checking if Weston leaks (e.g. with
>   Valgrind)
> - Running tests manually on a backend that is not x11 or wayland,
>   especially the backends that require weston-launch, and therefore
>   cannot be used with the 'make check' machinery.
> 
> This change should not affect 'make check' behaviour, because there
> WESTON_TEST_CLIENT_PATH is always set.

That's pretty useful, applied.

Kristian

> Cc: U. Artie Eoff <ullysses.a.eoff at intel.com>
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  tests/weston-test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/weston-test.c b/tests/weston-test.c
> index 0536be4..aebe57d 100644
> --- a/tests/weston-test.c
> +++ b/tests/weston-test.c
> @@ -213,7 +213,7 @@ idle_launch_client(void *data)
>  
>  	path = getenv("WESTON_TEST_CLIENT_PATH");
>  	if (path == NULL)
> -		exit(EXIT_FAILURE);
> +		return;
>  	pid = fork();
>  	if (pid == -1)
>  		exit(EXIT_FAILURE);
> -- 
> 1.8.1.5
> 


More information about the wayland-devel mailing list