[PATCH] src/shell.c: set black_surface->width and height

Kristian Høgsberg hoegsberg at gmail.com
Fri Nov 29 16:12:50 PST 2013


On Fri, Nov 29, 2013 at 11:18:14AM +0800, Xiong Zhang wrote:
> From: XiongZhang <xiong.y.zhang at intel.com>

Btw, it looks like you have your email name set up in .gitconfig as
"XiongZhang" not "Xiong Zhang". Is that intentional?  I've edited it
to "Xiong Zhang" as I commit seeing how your sign-off below has the
space in it.

Kristian

> full screen black_surface doesn't have associated wl_buffer, so
> black_surface->width and height can't get value through
> weston_surface_commit(). then weston_surface_damage(black_surface)
> will be wrong in shell_stack_fullscreen(), the result is that we 
> can't see a full screen view whe APP window's size isn't equal to 
> output's size like running weston-gears
> 
> Signed-off-by: Xiong Zhang <xiong.y.zhang at intel.com>
> ---
>  src/shell.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/shell.c b/src/shell.c
> index 605f090..ebcf3e2 100644
> --- a/src/shell.c
> +++ b/src/shell.c
> @@ -2254,6 +2254,8 @@ create_black_surface(struct weston_compositor *ec,
>  	pixman_region32_init_rect(&surface->opaque, 0, 0, w, h);
>  	pixman_region32_fini(&surface->input);
>  	pixman_region32_init_rect(&surface->input, 0, 0, w, h);
> +	surface->width = w;
> +	surface->height = h;
>  
>  	weston_view_configure(view, x, y, w, h);
>  
> -- 
> 1.8.3.2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list