[PATCH v2] Post buffer release events instead of queue when no frame callback

Jason Ekstrand jason at jlekstrand.net
Wed Oct 2 07:14:00 PDT 2013


All,
Perhaps a simpler approach would be better.  We could add a function to
wayland-server called wl_client_post_event_queue which would simply set the
wants_flush flag on the client connection. This function would be fast
,require no I/O, and safe to call multiple times so Weston could simply
call it on all clients with surfaces visible on the output in question at
the time when it would call frame events.  Then, when the event loop
flushes the clients, the release events will get sent out.
--Jason Ekstrand
On Sep 25, 2013 11:47 AM, "Tomeu Vizoso" <tomeu at tomeuvizoso.net> wrote:

> On 16 September 2013 17:28, Neil Roberts <neil at linux.intel.com> wrote:
>
>>
>> Here is a second version of the patch to do the posting. It makes the
>> patch for doing the queue disabling redundant.
>>
>
> Have done some testing on the RPi and this patch allows me not having to
> sync in a loop while waiting for buffer releases in SwapBuffers.
>
> I'm a bit concerned though about applications that install frame callbacks
> for reasons other than knowing when to start to draw, such as gathering
> timing statistics. I'm also concerned about making things more complicated
> and thus harder to debug.
>
> I have seen a flag proposed to enable or disable the queueing of release
> events, but I'm not sure what would make most sense to be the default value
> of it.
>
> Regards,
>
> Tomeu
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20131002/eb42f6bd/attachment.html>


More information about the wayland-devel mailing list