[PATCH 1/4] input: Add core API to update the keymap

[Daniel Stone]

Hi,

On 7 October 2013 14:32, Rui Matos <tiagomatos at gmail.com> wrote:
> @@ -1623,6 +1623,44 @@ weston_compositor_xkb_destroy(struct weston_compositor *ec)
>  }
>  #endif
>
> +WL_EXPORT void
> +weston_seat_update_keyboard(struct weston_seat *seat, struct xkb_keymap *keymap)

This should be weston_seat_update_keymap, I think.

> +{
> +       struct wl_resource *resource;
> +
> +       if (!seat->keyboard)
> +               return;
> +
> +#ifdef ENABLE_XKBCOMMON
> +       if (seat->compositor->use_xkbcommon) {

Please make this a negative return, i.e.:
if (!seat->compositor->use_xkbcommon)
        return;

[...]

Cheers,
Daniel