[PATCH weston] Add a way to update the keymap

Ran Benita ran234 at gmail.com
Mon Oct 7 20:16:33 CEST 2013


On Mon, Oct 07, 2013 at 03:32:15PM +0200, Rui Matos wrote:
> We'll need something like this in mutter-wayland to allow people to
> add/change their keyboard layouts with gnome-control-center so I
> figured I'd start by implementing the basics in weston first.
> 
> There's an implementation for a couple of backends and a fix for the
> client side which would leak on keymap events.

There should be some release note about this, otherwise applications
will start leaking memory for no apparent reason (I think most of them
just copied the relevant code from the Weston clients).

> Comments welcome, especially about the state handling - right now I'm
> just reseting the XKB state but I'm not sure this is the correct thing
> to do.

At least retaining the locked modifiers (and therefore the LED state in
most cases) would be nice, and not too problematic I think (though some
edge cases are expected).

(Also, the keymap updating in compositor-x11 is currently not optimal, we
should really be listening for XKB protocol events rather than the
rules property changes. But this is pending an XCB release at least,
which I can only hope will happen sometime this decade :)

Ran

> 
> Rui
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list