[PATCH v2 4/4] launcher: add logind backend

[David Herrmann]

Hi

On Tue, Oct 22, 2013 at 1:56 AM, Kristian Høgsberg <hoegsberg at gmail.com> wrote:
> On Tue, Oct 22, 2013 at 12:28:09AM +0200, David Herrmann wrote:
>> Instead of connecting to weston-launch from launcher-util, we now try to
>> connect to logind first. If logind provides session-devices, we use them.
>> If not, we fall back to the old weston-launch facility.
>
> Thanks, I've committed this series and pushed it.  There are still
> issues with this - I tried vt switching to a text mode vt and it hung
> up weston - but I want to merge this early on so we can start using it
> and fix all the issues.  To test this I manually edited my
> /etc/dbus-1/system.d/a/src/login/org.freedesktop.login1.conf to the
> effect of commit d7d1c8f983599dca6ee30229375215978657c072 from
> systemd.  I think we should add new wl_event_loop API instead of using
> the dummy eventfd.  Finally, we use return -1 and setting errno in
> wayland/weston, not return -ENOMEM.

The VT issue only happens if you switch VTs while weston is rendering.
I was able to trigger it myself. The problem is that drmModePageFlip()
fails and we never call weston_output_finish_frame(), thus never
re-enabling input-handling. I fixed that and will send the patches
after this mail.
Btw., if you lock-up weston like this, you can still ssh into your
machine and run "sudo chvt 7" and this will work. That's the beauty of
logind-util.c.

errno/-1.. whoops, totally forgot about that. Will fix it up.

Regarding wl_event_loop.. what I need is wl_event_source_check()
without an underlying source. So maybe I can allow
wl_event_source_check() on idle sources? Currently not possible as
idle-sources and wl_event_source_check() use the same list-head.

> But let's fix these things and improve over the next few commits.  I'm
> excited to have the login support in weston and it's awesome to just
> run 'weston' from the VT and have it come up running as 'krh'.

It feels great, doesn't it? :) systemd-logind VT-handling is also
almost finished.

Thanks
David