[PATCH 2/2] input: Warn if the touch point up and down events get out of sync

Neil Roberts neil at linux.intel.com
Tue Sep 24 14:49:41 PDT 2013

Bill Spitzak <spitzak at gmail.com> writes:

> I really really think this idea should be changed. Clients should just
> be prepared for excess up and down events, and excess focus in/out.
> Avoiding them becomes nearly impossible as you are probably noticing,
> and pretty much means the compositor must maintain the state of
> *EVERY* button for *EVERY* client.

In this case the problem is that Weston is internally missing some touch
up events and it doesn't even involve the clients. Weston really needs
to know how many touch points are pressed so that it can tell if a new
touch is the first one in order to decide which surface to send the
events to. I don't think there is a good way to do this without assuming
the up and down events we get from the input driver are consistent. This
patch could help catch problems like that in future.

- Neil
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

More information about the wayland-devel mailing list