[PATCH v2 2/2] compositor: check if seteuid worked

[Damian, Alexandru]

Funky, I tested the correct patch and then submitted this garbage.

Thanks for spotting this, new patch in the mail.

Alex


On Wed, Sep 25, 2013 at 2:36 PM, Emilio Pozuelo Monfort
<pochu27 at gmail.com>wrote:

> Hi,
>
> On 25/09/13 14:48, Alex DAMIAN wrote:
> > From: Alexandru DAMIAN <alexandru.damian at intel.com>
> >
> > Checking the return value from seteuid in
> > order to not launch clients with the wrong effective uid.
> >
> > Signed-off-by: Alexandru DAMIAN <alexandru.damian at intel.com>
> > ---
> >  src/compositor.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/src/compositor.c b/src/compositor.c
> > index bc4837f..2a16f52 100644
> > --- a/src/compositor.c
> > +++ b/src/compositor.c
> > @@ -247,8 +247,11 @@ child_client_exec(int sockfd, const char *path)
> >       sigfillset(&allsigs);
> >       sigprocmask(SIG_UNBLOCK, &allsigs, NULL);
> >
> > -     /* Launch clients as the user. */
> > -     seteuid(getuid());
> > +     /* Launch clients as the user. Do not lauch clients with wrong
> euid.*/
> > +     if (seteuid(getuid()) -1) {
>
> Missing == operator; this code won't build as is.
>
> Emilio
>
> > +             weston_log("compositor: failed seteuid\n");
> > +             return;
> > +     }
> >
> >       /* SOCK_CLOEXEC closes both ends, so we dup the fd to get a
> >        * non-CLOEXEC fd to pass through exec. */
> >
>
>


-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20130925/d650dff0/attachment.html>