[PATCH weston 0/8] wl_viewport enhancements

[Pekka Paalanen]

On Tue, 1 Apr 2014 16:11:20 -0700
Kristian Høgsberg <hoegsberg at gmail.com> wrote:

> On Fri, Mar 14, 2014 at 02:38:10PM +0200, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > Hi,
> > 
> > this series replaces the first 5 patches from
> > http://lists.freedesktop.org/archives/wayland-devel/2014-March/013580.html
> > 
> > Compared to the old series, this series carries the same 5 patches
> > rebased on top of the current master branch. It adds a tiny fix
> > (patch 4).
> > 
> > The big thing added in this series is patch 7, which adds two new
> > wl_viewport requests for setting the source rectangle and destination
> > size separately. This will be needed by the Presentation extension,
> > which classifies source rectangle as buffer state and destination size
> > as surface state, hence going through different commit paths. Clients
> > will need a way to set these separately.
> > 
> > We now also define what it means if source rectangle is set, but
> > destination size is not set, and vice versa.
> > 
> > This patch series does not yet change the wl_surface.commit behaviour.
> > 
> > When wl_scaler/wl_viewport eventually migrates to Wayland, my intention
> > is to drop the wl_viewport.set request and the error codes. I guess
> > this would also need to rename the global interface, which gives us
> > the opportunity to change the interface style from factory to
> > something else, if we want.
> 
> Series looks good, the protocol change makes sense.

Hi Kristian,

thanks for merging this, but you didn't comment anything on the
discussion about the 0x0 size and negative width/height. Are you happy
with the current semantics, or did you just miss the discussion in
this email thread?

More importantly, should I be changing it before weston 1.5 goes into
freeze?

Btw. did you announce the 1.5 release schedule? I couldn't find it in
the archives.


Thanks,
pq