[PATCH weston v4 15/15] Add a screen sharing plugin

[Andrew Wedgbury]

Hi,

On Wed, 2 Apr 2014, Jason Ekstrand wrote:

> 
> 
> On Apr 2, 2014 8:31 AM, "Manuel Bachmann" <manuel.bachmann at open.eurogiciel.org> wrote:
> >
> > HI Jason,
> >  
> > Thanks for submitting this interesting patch ; just tested it, works very well !
> >  
> > There's one missing thing, though : in "screen-share.c", you're using the "os_create_create_anonymous_file()" function, which takes an off_t  as a
> parameter.
> > To make sure that off_t is defined as 64-bit, even on 32-bit systems, you should
> >  
> > #include "config.h"
> >  
> > at the beginning ; otherwise building on a 32-bit OS will break.
> 
> Thanks, Manuel.  I'll get that fixed in my local version and make sure it gets in the next patch series.
> 
> Thanks,
> --Jason Ekstrand

I just ran into this one too, also doing a 32bit build.

I think there's a more general issue here too - in os_compatibility.h, 
sys/types.h is included before config.h, which means that anything 
including this header may get the incorrect size for off_t - in the case 
where they haven't already included config.h followed by sys/types.h (or 
something else that includes it). It would probably be worth swapping 
these round.

This won't fix the issue in screen-share though, as Manuel points out, 
you need to include config.h before anything else.

---
Andrew Wedgbury <andrew.wedgbury at realvnc.com>