[PATCH] Add an option to disable client initiated resizes

Hardening rdp.effort at gmail.com
Wed Apr 2 23:33:51 PDT 2014


Le 03/04/2014 02:08, Bill Spitzak a écrit :
> Hardening wrote:
>
>> +            if (!settings->DesktopResize) {
>> +                /* peer does not support desktop resize */
>> +                weston_log("%s: client doesn't support resizing,
>> closing connection\n", __FUNCTION__);
>> +                client->Close(client);
>
>> +            target_mode = ensure_matching_mode(&output->base,
>> &new_mode);
>> +            if (!target_mode) {
>> +                weston_log("client mode not found\n");
>> +                return FALSE;
>> +            }
>
> One failure mode is fatal, while the other one just returns FALSE? Both
> just mean that weston's size is different than the RDP window size, so I
> think the results should be the same.

Good catch,
at the end the behaviour is the same as returning FALSE for 
postConnect() closes the connection. But let's make it consistent and 
return FALSE in all error cases. I'm sending a v2.

Thanks for the review.

-- 
David FORT
website: http://www.hardening-consulting.com/


More information about the wayland-devel mailing list