[PATCH wayland] connection: fix a format string typo in error message

Pekka Paalanen ppaalanen at gmail.com
Tue Apr 22 06:33:35 PDT 2014


On Tue, 22 Apr 2014 16:03:12 +0300
Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> ---
>  src/connection.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/connection.c b/src/connection.c
> index 63b0592..47ee556 100644
> --- a/src/connection.c
> +++ b/src/connection.c
> @@ -724,7 +724,7 @@ wl_connection_demarshal(struct wl_connection *connection,
>  			}
>  
>  			if (wl_map_reserve_new(objects, id) < 0) {
> -				wl_log("not a valid new object id (%d), "
> +				wl_log("not a valid new object id (%u), "
>  				       "message %s(%s)\n",
>  				       id, message->name, message->signature);
>  				errno = EINVAL;

Yeah, seems trivially correct. One would see the difference, if there
was a problem with a server-created object.

It looks like wl_connection_demarshal() would have several other places
too, that print like "object(%d)", which I think would need to be %u.


Thanks,
pq


More information about the wayland-devel mailing list