[PATCH weston-ivi-shell v4 7/9] Add refernce image files for ivi-hmi-controller

[Pekka Paalanen]

On Mon, 17 Mar 2014 15:29:56 +0900
Nobuhiko Tanibata <NOBUHIKO_TANIBATA at xddp.denso.co.jp> wrote:

> Signed-off-by: Nobuhiko Tanibata <NOBUHIKO_TANIBATA at xddp.denso.co.jp>
> ---
> 
> Changes for v2:
>  - squash Makefile to this patch
> 
> Changes for v3 and v4
>  - nothing. Version number aligned to the first patch
> 
>  data/Makefile.am             |  14 +++++++++++++-
>  data/background.png          | Bin 0 -> 245579 bytes

You could use a simpler and smaller placeholder background, I guess.

>  data/fullscreen.png          | Bin 0 -> 3406 bytes
>  data/home.png                | Bin 0 -> 4629 bytes
>  data/icon_ivi_clickdot.png   | Bin 0 -> 39523 bytes
>  data/icon_ivi_flower.png     | Bin 0 -> 24475 bytes
>  data/icon_ivi_simple-egl.png | Bin 0 -> 29316 bytes
>  data/icon_ivi_simple-shm.png | Bin 0 -> 71120 bytes
>  data/icon_ivi_smoke.png      | Bin 0 -> 46577 bytes

These icons seems to be pretty big...

>  data/panel.png               | Bin 0 -> 41955 bytes
>  data/random.png              | Bin 0 -> 4891 bytes
>  data/sidebyside.png          | Bin 0 -> 3929 bytes
>  data/tiling.png              | Bin 0 -> 5620 bytes
>  13 files changed, 13 insertions(+), 1 deletion(-)
>  create mode 100644 data/background.png
>  create mode 100644 data/fullscreen.png
>  create mode 100644 data/home.png
>  create mode 100644 data/icon_ivi_clickdot.png
>  create mode 100644 data/icon_ivi_flower.png
>  create mode 100644 data/icon_ivi_simple-egl.png
>  create mode 100644 data/icon_ivi_simple-shm.png
>  create mode 100644 data/icon_ivi_smoke.png
>  create mode 100644 data/panel.png
>  create mode 100644 data/random.png
>  create mode 100644 data/sidebyside.png
>  create mode 100644 data/tiling.png
> 
> diff --git a/data/Makefile.am b/data/Makefile.am
> index a7cc944..2aa6e5c 100644
> --- a/data/Makefile.am
> +++ b/data/Makefile.am
> @@ -9,7 +9,19 @@ dist_westondata_DATA =				\
>  	icon_window.png				\
>  	sign_close.png				\
>  	sign_maximize.png			\
> -	sign_minimize.png
> +	sign_minimize.png			\
> +	background.png				\
> +	tiling.png				\
> +	fullscreen.png				\
> +	panel.png				\
> +	random.png				\
> +	sidebyside.png				\
> +	home.png				\
> +	icon_ivi_clickdot.png			\
> +	icon_ivi_flower.png			\
> +	icon_ivi_simple-egl.png			\
> +	icon_ivi_simple-shm.png			\
> +	icon_ivi_smoke.png
>  
>  if HAVE_RSVG_CONVERT
>  wayland_icon_png = wayland.png
> diff --git a/data/background.png b/data/background.png
> new file mode 100644
> index 0000000000000000000000000000000000000000..60c317c945ae3a8c9f0875cc59a80fd248692fac
> GIT binary patch
> literal 245579

Hi,

posting binary patches to the mailing list is slightly useless, because
the content cannot really be reviewed by just reading the email. It is
very good, that you separated this into a patch of its own.

In the future, I would suggest you skip sending this patch to the
mailing list or remove all the binary stuff and leave just the plain
text part like I did in this reply, and publish a git branch with the
complete series.

Another benefit of a git branch is that we can easily see your
branching point, when coming back to it much later.


Thanks,
pq