[PATCH libinput 06/24] tests: drain events before testing scroll events in test-pointer

Peter Hutterer peter.hutterer at who-t.net
Sun Apr 27 22:06:35 PDT 2014


On Mon, Apr 21, 2014 at 07:11:15PM +0200, Carlos Garnacho wrote:
> This is so LIBINPUT_EVENT_POINTER_AXIS_FRAME events remaining from
> previous tests are discarded.

please instead update the tests so we pull the frame event off before we test
the next series. it safeguards us against accidental behaviour changes.

Cheers,
   Peter

 
> Signed-off-by: Carlos Garnacho <carlosg at gnome.org>
> ---
>  test/pointer.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/test/pointer.c b/test/pointer.c
> index 59fe818..ecb7dbd 100644
> --- a/test/pointer.c
> +++ b/test/pointer.c
> @@ -137,6 +137,8 @@ test_wheel_event(struct litest_device *dev, int which, int amount)
>  	const int scroll_step = 10;
>  	int expected = amount * scroll_step;
>  
> +	litest_drain_events(li);
> +
>  	/* mouse scroll wheels are 'upside down' */
>  	if (which == REL_WHEEL)
>  		amount *= -1;
> -- 
> 1.9.0
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 


More information about the wayland-devel mailing list