[PATCH 1/6] compositor: Fix the documentation for surface->configure

Bryce W. Harrington b.harrington at samsung.com
Mon Apr 28 16:24:50 PDT 2014


On Mon, Apr 28, 2014 at 11:19:27AM -0400, Jasper St. Pierre wrote:
> It's called on commit, not on attach. Additionally, correct the
> interface name to be wl_surface, not surface.
> ---
>  src/compositor.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/compositor.h b/src/compositor.h
> index 03d8992..c913f54 100644
> --- a/src/compositor.h
> +++ b/src/compositor.h
> @@ -908,9 +908,9 @@ struct weston_surface {
>  	} pending;
>  
>  	/*
> -	 * If non-NULL, this function will be called on surface::attach after
> +	 * If non-NULL, this function will be called on wl_surface::commit after
>  	 * a new buffer has been set up for this surface. The integer params
> -	 * are the sx and sy paramerters supplied to surface::attach .
> +	 * are the sx and sy paramerters supplied to wl_surface::attach .

parameters is misspelled too.

>  	 */
>  	void (*configure)(struct weston_surface *es, int32_t sx, int32_t sy);
>  	void *configure_private;

Reviewed-by: Bryce Harrington <b.harrington at samsung.com>

> -- 
> 1.9.0
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list