[PATCH 6/6] window: Add a simple getenv to force SHM rendering

Kristian Høgsberg krh at bitplanet.net
Tue Apr 29 13:07:57 PDT 2014


On Tue, Apr 29, 2014 at 5:35 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Mon, 28 Apr 2014 11:19:32 -0400
> "Jasper St. Pierre" <jstpierre at mecheye.net> wrote:
>
>> ---
>>  clients/window.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/clients/window.c b/clients/window.c
>> index d822af7..3897440 100644
>> --- a/clients/window.c
>> +++ b/clients/window.c
>> @@ -4338,11 +4338,11 @@ surface_create(struct window *window)
>>       return surface;
>>  }
>>
>> -static window_buffer_type
>> +static enum window_buffer_type
>>  get_preferred_buffer_type(struct display *display)
>>  {
>>  #ifdef HAVE_CAIRO_EGL
>> -     if (display->argb_device)
>> +     if (display->argb_device && !getenv("TOYTOOLKIT_NO_EGL"))
>>               return WINDOW_BUFFER_TYPE_EGL_WINDOW;
>>  #endif
>>
>
> Nice.
>
> I wonder, would it be time to finally just drop cairo-egl completely?
> It does raise the question on what to do with weston-gears and
> weston-screensaver. ISTR that krh was not fond of using sub-surfaces
> for them, so... just turn them into simple-egl kind of clients? Did we
> already have the decorations code easily integrable to non-cairo GL
> apps, maybe stemming from the wayland-backend work?

I'd like to drop cairo-egl, but not in a way that makes window.c shm
only.  I'd like it to use GL by default and use cairo for rendering
assets, for example, render the frame in cairo, but use gl to stretch
and scale it and composite the title on top.

Kristian

> That might be a nice newbie task.
>
>
> Thanks,
> pq
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list