[PATCH weston] simple-egl: Clean up unused frame_listener

Pekka Paalanen ppaalanen at gmail.com
Fri Aug 15 05:54:50 PDT 2014


On Mon, 11 Aug 2014 18:20:12 +0200
"Nils Chr. Brause" <nilschrbrause at gmail.com> wrote:

> On Mon, Aug 11, 2014 at 10:08 AM, Boyan Ding <stu_dby at 126.com> wrote:
> 
> > Unused since commit 1e65840b6103197a684a551925a58fb1ae6c40e3
> >
> > Signed-off-by: Boyan Ding <stu_dby at 126.com>
> > ---
> >  clients/simple-egl.c | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/clients/simple-egl.c b/clients/simple-egl.c
> > index 2097b4c..f23fb8c 100644
> > --- a/clients/simple-egl.c
> > +++ b/clients/simple-egl.c
> > @@ -367,8 +367,6 @@ destroy_surface(struct window *window)
> >                 wl_callback_destroy(window->callback);
> >  }
> >
> > -static const struct wl_callback_listener frame_listener;
> > -
> >  static void
> >  redraw(void *data, struct wl_callback *callback, uint32_t time)
> >  {
> > @@ -469,10 +467,6 @@ redraw(void *data, struct wl_callback *callback,
> > uint32_t time)
> >         window->frames++;
> >  }
> >
> > -static const struct wl_callback_listener frame_listener = {
> > -       redraw
> > -};
> > -
> >  static void
> >  pointer_handle_enter(void *data, struct wl_pointer *pointer,
> >                      uint32_t serial, struct wl_surface *surface,
> >
> 
> This is indeed unused and may be confusing for beginners.
> Looks good to me. :)
> 
> Reviewed-by: Nils Chr. Brause <nilschrbrause at gmail.com>
> 

Works for me, pushed.


Thanks,
pq


More information about the wayland-devel mailing list