[PATCH 2/2] compositor: add a way to change the keyboard leds

Daniel Stone daniel at fooishbar.org
Wed Aug 20 00:40:06 PDT 2014


Hi,

On 19 August 2014 11:25, Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> This adds a function weston_keyboard_set_leds() which can be used
> to change the state of the num lock and the caps lock leds.
> Only the evdev backend supports this, since it doesn't make sense
> for embedded sessions.
>

This is missing the bit for actual evdev support, as well as a user. Please
also move the variable declarations to the top of the function. The
leds/active naming is a bit confusing too; something about mask/value would
be nice, as well as getting rid of the complex ternary statements.

Other than that, looks good to me, thanks.

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140820/2e90f9ce/attachment.html>


More information about the wayland-devel mailing list