[PATCH 2/2] compositor: add a way to change the keyboard leds

Daniel Stone daniel at fooishbar.org
Thu Aug 21 00:37:17 PDT 2014


Hi,
Last nitpick, sorry ...

On Wednesday, August 20, 2014, Giulio Camuffo <giuliocamuffo at gmail.com>
wrote:
>
> +       mods_depressed =
> xkb_state_serialize_mods(keyboard->xkb_state.state,
> +                                               XKB_STATE_DEPRESSED);
> +       mods_latched = xkb_state_serialize_mods(keyboard->xkb_state.state,
> +                                               XKB_STATE_LATCHED);
> +       mods_locked = xkb_state_serialize_mods(keyboard->xkb_state.state,
> +                                               XKB_STATE_LOCKED);
> +       group = xkb_state_serialize_group(keyboard->xkb_state.state,
> +                                      XKB_STATE_EFFECTIVE);
> +
> +       num = (1 << keyboard->xkb_info->mod2_mod);
> +       caps = (1 << keyboard->xkb_info->caps_mod);


I still don't really believe the non-xkbcommon build should exist, but
shouldn't all this be #ifdef'ed?

Cheers,
Daniel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140821/9001934a/attachment.html>


More information about the wayland-devel mailing list