[PATCH weston 1/3] evdev/libinput: sync the leds of keyboards with the xkb state

[Giulio Camuffo]

2014-08-21 10:34 GMT+03:00 Daniel Stone <daniel at fooishbar.org>:
> Hi,
>
>
> On Wednesday, August 20, 2014, Giulio Camuffo <giuliocamuffo at gmail.com>
> wrote:
>>
>> When a new keyboard is found (including during startup) sync its leds
>> with the internal state of the xkb map.
>> It appears that by setting them immediately when getting the new device
>> we're racing with the kernel or something, which wants to turn all the
>> leds off, so we use a timer.
>
>
> Ugh. If you've your own kernel to hand, I'd hack it to WARN_ON(1) on LED
> updates, so you can track where the rogue update is coming from. My guess is
> that switching VT breaks it, so it might work if you instead trigger an
> update of all LED state on every VT enter?

Switching VT is another matter, because all the keyboard devices are
removed so the xkb state is lost, so when returning to weston's vt we
don't know anymore which leds are supposed to be on.
This patch just fixes keyboard hotplugging, besides turning the leds
off at startup.

Besides that, i honestly don't know what WARN_ON is, and i haven't
compiled a kernel in a few years. :)

--
Giulio


>
> Cheers,
> Daniel