[PATCH weston 3/3] compositor: add an option to set the default numlock value

[Giulio Camuffo]

2014-08-21 10:31 GMT+03:00 Daniel Stone <daniel at fooishbar.org>:
> Hi,
>
>
> On Wednesday, August 20, 2014, Giulio Camuffo <giuliocamuffo at gmail.com>
> wrote:
>>
>> Add a new "numlock-on" option in the [keyboard] section of weston.ini
>> which, if set to true, is used to enable the numlock of the keyboards
>> attached at startup.
>
>
> I'm fine with this in principle, but would like to see this test if it's
> possible (i.e. not nesting / led_update() is valid), and issue a rejection
> message to the log otherwise.

Uhm, the option is defined as "set the numlock value *if* the backend
supports it". Having it print out a warning line every time i start
weston in X would be just noise, imho.
On the other hand, weston_keyboard_set_leds() returns -1 if it failed,
so a user can print a warning where it makes sense.

--
Giulio


>
> Cheers,
> Daniel