[PATCH weston 1/3] evdev/libinput: sync the leds of keyboards with the xkb state

[Daniel Stone]

On 21 August 2014 13:17, Giulio Camuffo <giuliocamuffo at gmail.com> wrote:

> 2014-08-21 15:06 GMT+03:00 Daniel Stone <daniel at fooishbar.org>:
> > On 21 August 2014 08:58, Giulio Camuffo <giuliocamuffo at gmail.com> wrote:
> >> Switching VT is another matter, because all the keyboard devices are
> >> removed so the xkb state is lost, so when returning to weston's vt we
> >> don't know anymore which leds are supposed to be on.
> >
> > Sure we do: the usual way is to release all keys on VT leave, resetting
> > latches but leaving locks as they are. So when they came back, just apply
> > the state that occurred as a result of that, rather than trying to
> maintain
> > a totally unknown state from whilst you were switched away, or reset it
> > completely.
>
> I mean the current weston code doesn't know the state anymore. Sure
> that can be fixed, but I think it should be another patch.


Oh yes, to be totally clear, that was really just an aside. It might be the
correct way to solve the problem if the LEDs get clobbered on VT switches
though, mind. ;)


> >> This patch just fixes keyboard hotplugging, besides turning the leds
> >> off at startup.
> >
> > Sure. I really, really don't like that timer though ... I'd rather just
> sit
> > this one out whilst we work out the correct thing to do though. If you've
> > got some time on your hands, looking at the VT-enter path would be good I
> > think; even if it doesn't make the first release, I think it'd make a
> good
> > stable-branch candidate.
>
> I agree the timer is ugly, but I have other priorities at the moment
> honestly, so I'm not going to spend big amount of time on this, at
> least yet. I'm fine with leaving this one be and getting only the
> other two in.
>

No problem. We can come back to it later. Thanks for dealing with all my
bikeshedding!

-d
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140821/b3e6d507/attachment.html>