[PATCH] Added destructor protocol to wl_data_device interface

Pekka Paalanen ppaalanen at gmail.com
Fri Aug 22 02:08:59 PDT 2014


On Tue, 19 Aug 2014 17:40:20 +0530
kabeer.khan at samsung.com wrote:

> From: "kabeer.khan" <kabeer.khan at kabeer-khan.(none)>
> 
> This is a fix to Bug# 81745
> 
> Signed-off-by: kabeer <kabeer.khan at samsung.com>
> ---
>  protocol/wayland.xml |    9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index 2d57f69..c3a9f28 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -569,8 +569,13 @@
>        <arg name="source" type="object" interface="wl_data_source"
> allow-null="true"/> <arg name="serial" type="uint" summary="serial of
> the event that triggered this request"/> </request>
> -
> -    <event name="data_offer">
> +	<request name="destroy" type="destructor">
> +      <description summary="destroy the data device">
> +        Destroy the data device.
> +      </description>
> +    </request>
> +	
> +	<event name="data_offer">
>        <description summary="introduce a new wl_data_offer">
>  	The data_offer event introduces a new wl_data_offer object,
>  	which will subsequently be used in either the

Hi,

this needs more work.
- there is an unwanted change in existing indentation
- you cannot add a destructor called 'destroy' after the version 1 of
  the interface has been published
- all interface version bumps are missing
- missing 'since' attribute
- needs companion patches to Weston to implement this

For an example of a similar addition, see Wayland commits
	3ed76204a9bb5dfe652113ea2e494ad688e22cea
	ea1fb51aae9fee7d416a0f2ba617f998cdee696d
and Weston commits
	69e25fc5386f045c93454b70e2055962e7de0358
	080311879ee68ba93b725ca51974c9fe222b9f99


Thanks,
pq


More information about the wayland-devel mailing list