[PATCH libinput 0/8] Add libinput_device_suspend() to disable devices

Peter Hutterer peter.hutterer at who-t.net
Mon Aug 25 15:12:22 PDT 2014


On Mon, Aug 25, 2014 at 10:23:09AM -0700, Bill Spitzak wrote:
> On 08/24/2014 05:44 PM, Peter Hutterer wrote:
> 
> >this is *not* about palm detection. palm detection is already always enabled
> >where possible and with the parameters sensible for that specific touchpad.
> >
> >This option is for the optional disabling of the touchpad when an external
> >mouse is connected. And that option is only necessary because we can't
> >guarantee that palm detection works 100% of the time.
> 
> I think I am still failing to explain what I am asking for.
> 
> 1. Disable: good, for exactly the reason you state, so that you can do
> thinks like turn it off when the mouse is plugged in without that being part
> of the touchpad driver.
> 
> 2. "smart" disable/enable: good. You certainly want to provide the ability
> to use any intelligence written into the driver.
> 
> 3. Enable: THIS IS THE ONE I WANT TO REMOVE. It seems like there should be
> no reason to bypass what was put in the driver to intelligently disable the
> touchpad.
> 
> My recommendation is to rename "smart disable" to "enable" and eliminate the
> proposed "enable" setting.
> 
> If in fact there is some problem with the driver so that you want to adjust
> the smart settings, something more complicated (and probably more
> driver-specific) than a boolean is going to be needed.

sigh. last email from me in this thread.

1) this is a configuration setting. libinput decides whether
disable/enable/... means "close the fd" or "process events only internally"
or anything else. you cannot enable a device libinput has decided to
disable, you can only ask to re-enable a device that you have previously
disabled.
1.1) Hence the proposed change to a configuration setting, and some other
renames
2) whether the touchpad should be disabled when the mouse is plugged in is a
user-specific setting. this is the sole feature of "smart disable" right
now, and it should be renamed to be less ambiguous
3) palm detection etc. is not exposed and independent of the
enable/disable settings.

Cheers,
   Peter


More information about the wayland-devel mailing list