[PATCH v2 1/2] Protocol: Add destructor to wl_data_device interface Fix for Bug# 81745

[Pekka Paalanen]

On Fri, 22 Aug 2014 19:16:49 +0530
kabeer.khan at samsung.com wrote:

> From: kabeer <kabeer.khan at samsung.com>
> 
> Signed-off-by: kabeer <kabeer.khan at samsung.com>
> ---
>  protocol/wayland.xml |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index bb457bc..1d3b24f 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -517,7 +517,7 @@
>  
>    </interface>
>  
> -  <interface name="wl_data_device" version="1">
> +  <interface name="wl_data_device" version="2">
>      <description summary="data transfer device">
>        There is one wl_data_device per seat which can be obtained
>        from the global wl_data_device_manager singleton.
> @@ -640,6 +640,13 @@
>        </description>
>        <arg name="id" type="object" interface="wl_data_offer" allow-null="true"/>
>      </event>
> +    
> +    <!-- Version 2 additions -->
> +    
> +    <request name="release" type="destructor" since="2">
> +      <description summary="destroy data device">
> +	  </description>
> +    </request>
>    </interface>
>  
>    <interface name="wl_data_device_manager" version="1">

Hi,

this is better, just one more thing. When you bump revision here, you
also need to bump the revision on wl_data_device_manager, because that
is the interface that creates wl_data_device objects. This applies
recursively, but wl_data_device_manager is a global, so there is no
interface above it to bump.

Since we are in the alpha phase, I will need another review on the
final series, too. Otherwise this will need to wait until 1.7
development cycle begins.


Thanks,
pq