[PATCH weston] simple-shm: remove an unnecessary call of wl_display_get_fd()

Pekka Paalanen ppaalanen at gmail.com
Thu Aug 28 01:59:43 PDT 2014


On Tue, 26 Aug 2014 21:25:22 +0200
"Nils Chr. Brause" <nilschrbrause at gmail.com> wrote:

> Since wl_display_get_fd() doesn't have any side effects, this is truly
> useless.
> 
> Reviewed-by: Nils Chr. Brause <nilschrbrause at gmail.com>
> 
> 
> 
> On Tue, Aug 26, 2014 at 2:59 PM, Ryo Munakata <ryomnktml at gmail.com> wrote:
> 
> > ---
> >  clients/simple-shm.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/clients/simple-shm.c b/clients/simple-shm.c
> > index b1c311f..c1cb386 100644
> > --- a/clients/simple-shm.c
> > +++ b/clients/simple-shm.c
> > @@ -393,8 +393,6 @@ create_display(void)
> >                 exit(1);
> >         }
> >
> > -       wl_display_get_fd(display->display);
> > -
> >         return display;
> >  }

Obviously correct nowadays, pushed.
Btw. there is another one, too. ;-)


Thanks,
pq


More information about the wayland-devel mailing list