Patch: fix weston crash (inline patch)

Andrew Engelbrecht sudoman at ninthfloor.org
Tue Dec 2 10:02:55 PST 2014


On 12/02/2014 12:18 PM, Andrew Engelbrecht wrote:
> I've attached a patch which fixes the crashing. I mimicked the code in
> the block above it without knowing the overall impact, so it needs
> review from a knowledgeable contributor.

here's the patch in non-attachment form:

diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
index bdfac23..9284a05 100644
--- a/xwayland/window-manager.c
+++ b/xwayland/window-manager.c
@@ -1326,7 +1326,9 @@ weston_wm_window_handle_state(struct
weston_wm_window *window,
 								WL_SHELL_SURFACE_FULLSCREEN_METHOD_DEFAULT,
 								0, NULL);
 		} else {
-			shell_interface->set_toplevel(window->shsurf);
+			if (window->shsurf)
+				shell_interface->set_toplevel(window->shsurf);
+
 			window->width = window->saved_width;
 			window->height = window->saved_height;
 			if (window->frame)




More information about the wayland-devel mailing list