[PATCH weston-ivi-shell v8 00/13] a reference shell for In-Vehicle Infotainment system
ppaalanen at gmail.com
Thu Dec 4 07:33:37 PST 2014
On Thu, 27 Nov 2014 09:00:03 +0200
Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Thu, 27 Nov 2014 13:07:20 +0900
> Nobuhiko Tanibata <nobuhiko_tanibata at xddp.denso.co.jp> wrote:
> > This is version 8 of ivi_shell patches reviewed by Pekka Paalanen
> > <pekka.paalanen at collabora.co.uk>.
> > Vesion 7 can be found here:
> > http://lists.freedesktop.org/archives/wayland-devel/2014-July/015971.html
> > Version 1 can be found here and this overviews what ivi_shell is:
> > http://lists.freedesktop.org/archives/wayland-devel/2014-March/013532.html
> > and
> > http://projects.genivi.org/wayland-ivi-extension
> > Version 6 enclosed an updated picture for overviewing of ivi-shell:
> > http://lists.freedesktop.org/archives/wayland-devel/2014-June/015616.html
> > For easier testing/review, this patch series can be found in my github
> > as well.
> > https://github.com/ntanibata/weston-ivi-shell/tree/weston-ivi-shell-1.6.0-WIP-11
> > Overview of Changes since version v7:
> > The patchset has been completely restructured so I don’t write all
> > changed per each patch here.
> > * Rebased on Weston master.
> > * Improvement of README.
> > * Coding sytle change, following
> > http://cgit.freedesktop.org/wayland/wayland/tree/doc/Contributing
> > * Clean up protocols and its descriptions, ivi-application.aml and
> > ivi-hmi-controller.
> > * Re-alignment of ivi-layout interfaces in ivi-layout-export.h. Which
> > interfaces should be exported by WL_EXPORT is re-aligned by that they
> > are needed by references of how to use ivi-layout interfaces;
> > hmi-controller and ivi-controller. One reference; hmi-controller is a
> > part of this patchset. Another one; ivi-controller is provided by GENIVI
> > wayland-ivi-extension project. The link to the project can be find in
> > REAME.
> > * Refinement of destruction logic of ivi_surface in ivi-shell.c and
> > ivi-layout.c
> > * Authorization check to restrict access from client to hmi-controller.
> > A client invoked by hmi-controller is allowed to access.
> > * Clean up weston-ivi-shell-user-interface which is reference of how to
> > use hmi-controller protocol. There are several unnecessary roundtrips.
> > It is fixed referring simple-shm code.
> > * Clean up clients; simpe-egl, simple-shm, and window to support
> > ivi-application protocol.
> > * This is not change yet. We are looking for merging ivi-layout.so into
> > ivi-shell.so.
> Hello Wayland community,
> as you can see, every patch has my Reviewed-by or Acked-by. This means
> the series is ready to be merged in my opinion.
> I shall wait for one week (till Thursday next week) for community
> reviews and opinions, so if you see something really wrong with this,
> speak up soon, please.
> All kinds of reviews are welcome, don't take my word for it. ;-)
> For the record, here is the diff-stat over the whole series:
> .gitignore | 1 +
> Makefile.am | 114 +-
> clients/ivi-shell-user-interface.c | 1310 ++++++++++++
> clients/simple-egl.c | 95 +-
> clients/simple-shm.c | 42 +
> clients/window.c | 67 +-
> configure.ac | 9 +
> data/COPYING | 28 +-
> data/background.png | Bin 0 -> 245579 bytes
> data/fullscreen.png | Bin 0 -> 3406 bytes
> data/home.png | Bin 0 -> 4629 bytes
> data/icon_ivi_clickdot.png | Bin 0 -> 39523 bytes
> data/icon_ivi_flower.png | Bin 0 -> 24475 bytes
> data/icon_ivi_simple-egl.png | Bin 0 -> 29316 bytes
> data/icon_ivi_simple-shm.png | Bin 0 -> 71120 bytes
> data/icon_ivi_smoke.png | Bin 0 -> 46577 bytes
> data/panel.png | Bin 0 -> 41955 bytes
> data/random.png | Bin 0 -> 4891 bytes
> data/sidebyside.png | Bin 0 -> 3929 bytes
> data/tiling.png | Bin 0 -> 5620 bytes
> ivi-shell/.gitignore | 1 +
> ivi-shell/README | 79 +
> ivi-shell/hmi-controller.c | 1718 ++++++++++++++++
> ivi-shell/input-panel-ivi.c | 391 ++++
> ivi-shell/ivi-layout-export.h | 683 +++++++
> ivi-shell/ivi-layout-private.h | 319 +++
> ivi-shell/ivi-layout-transition.c | 1111 ++++++++++
> ivi-shell/ivi-layout.c | 2780 ++++++++++++++++++++++++++
> ivi-shell/ivi-shell.c | 498 +++++
> ivi-shell/ivi-shell.h | 64 +
> ivi-shell/weston.ini.in | 96 +
> protocol/ivi-application.xml | 99 +
> protocol/ivi-hmi-controller.xml | 97 +
> 33 files changed, 9572 insertions(+), 30 deletions(-)
> The changes outside the new directory ivi-shell/ are minor.
since there was no opposition, this series is now pushed.
In irc, there was a worry that merging this might make changes to
Weston core harder to do and so discourage people from contributing. I
agree it may be a valid concern, but let's see how it goes.
If anyone feels like dropping some change they were working on just
because of ivi-shell, let me and Tanibata know, and we'll see what we
More information about the wayland-devel