[PATCH 1/1] weston-launch: alter tty command line parameter semantics

Damian, Alexandru alexandru.damian at intel.com
Mon Dec 8 02:34:16 PST 2014


What annoyed me was weston silently ignoring the tty argument in certain
conditions (you have to specify a new user argument while being root).

I reasoned that user access to the tty should be set up by the kernel
policies, and we should not enforce the policy at weston level. If the
system is configured in this way, then a user with enough permissions can
start up weston under his account without having to have root permissions.


In the end, I can use the openvt workaround, if you are concerned about the
security implications.

Cheers,
Alex

On Mon, Dec 8, 2014 at 9:47 AM, Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
>
> On Wednesday, October 2, 2013, Alex DAMIAN <alexandru.damian at intel.com>
> wrote:
>>
>> Current behaviour of the tty parameter is to take effect
>> only if there is a new user starting up.
>>
>> Since it is useful to start weston-launch with a command line
>> specified tty, I'm changing the semantics of the tty parameter:
>>
>> * the argument to the --tty parameter is now mandatory
>> * if specified, weston-launch will try to run on the specified tty
>> * otherwise, it will continue to try to find the first free console
>>
>> This patch allows starting weston-launch over a ssh connection,
>> for example, with the current user.
>>
>
> Sorry about the long latency on this.
>
> Your commit message leaves out the most important change - that non-root
> users can now specify arbitrary TTYs. This makes me a little nervous, even
> though it will fail if anyone already has the VT open.
>
> I've been using openvt -- weston-launch --user=foo, over SSH. Would that
> be an adequate replacement for you?
>
> Cheers,
> Daniel
>



-- 
Alex Damian
Yocto Project
SSG / OTC
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20141208/dfd2c7da/attachment.html>


More information about the wayland-devel mailing list