Fwd: [PATCH libinput] evdev: Ensure the libevdev object receives the new fd on resume

Carlos Garnacho carlosg at gnome.org
Wed Dec 10 04:17:30 PST 2014


Doh, resending to list from the subscribed account...


Hey Peter :),

On Wed, Dec 10, 2014 at 1:40 AM, Peter Hutterer
<peter.hutterer at who-t.net> wrote:
>
> On Tue, Dec 09, 2014 at 03:55:32PM +0100, Carlos Garnacho wrote:
> > Otherwise, input_events will be attempted to read from the wrong place,
> > which also leaves the right/current fd with pending data to be read,
> > making the epoll fd wake up constantly.
> >
> > Signed-off-by: Carlos Garnacho <carlosg at gnome.org>
>
> huh, this seems like something the test should've caught. I'll look into
> that, meanwhile - merged locally, thanks


I think this is because the tests are neat enough to have the same fd
number reused, so the bug doesn't surface there. In more chaotic
environments it'd have higher chances to get a different one, leading
to this. This got me scratching my head too as to why didn't it happen
even if I changed tests to do the exact same.

I can also make a patch adding some testcase triggering this situation
if you want.

Cheers,
  Carlos


More information about the wayland-devel mailing list