[PATCH] Remove explicit dependency on $(WAYLAND_LIBS)

Pekka Paalanen ppaalanen at gmail.com
Thu Dec 11 07:35:40 PST 2014


On Wed, 03 Dec 2014 14:33:38 +0100
Olivier Fourdan <ofourdan at redhat.com> wrote:

> Hi
> 
> I was trying to build XWayland as per the recipe from 
> http://wayland.freedesktop.org/xserver.html and ran into an issue 
> because I have the Wayland libs installed in a non-standard location 
> (from http://wayland.freedesktop.org/building.html)
> 
> Basically, xserver/hw/xwayland/Makefile.am specifies 
> "Xwayland_DEPENDENCIES = $(XWAYLAND_LIBS)" which will break because 
> XWAYLAND_LIBS also contains the statements "-L/path/to/the/lib" and that 
> breaks the build with:
> 
> make[2]: *** No rule to make target '-L/path/to/the/lib', needed by 
> 'Xwayland'.  Stop.
> make[2]: Leaving directory '/home/ofourdan/src/wayland/xserver/hw/xwayland'
> 
> I am not sure why "Xwayland_DEPENDENCIES = $(XWAYLAND_LIBS)" was added 
> in the first place, it comes from a huge commit (6e539d88), but I 
> suspect it's not needed and it might be better not have it (at least it 
> builds successfully without), thus the patch attached.

Hi,

this is an Xwayland patch, and as Xwayland lives in the xserver
repository, this patch should be sent to
xorg-devel at lists.freedesktop.org

CC'ing wayland-devel@ would be nice, though.

Please, use git-send-email next time to send the patch inline. It is a
bit difficult to review as an attachment.


Thanks,
pq


More information about the wayland-devel mailing list