[PATCH 3/3] touchpad: Use TOUCHPAD_MIN_SAMPLES in tp_get_delta
peter.hutterer at who-t.net
Mon Dec 15 16:25:44 PST 2014
On Fri, Dec 12, 2014 at 01:15:49PM +0100, Hans de Goede wrote:
> On 10-12-14 04:34, Peter Hutterer wrote:
> >On Tue, Dec 09, 2014 at 12:47:11PM +0100, Hans de Goede wrote:
> >>Use TOUCHPAD_MIN_SAMPLES in tp_get_delta rather then hardcoding "4".
> >>Also remove the superfluous TOUCHPAD_MIN_SAMPLES check before calling
> >>tp_get_delta in tp_get_pointer_delta, this is not necessary as tp_get_delta
> >>already checks itself.
> >Right, though note that you're now passing the initial 0/0 deltas into the
> >filter and thus feed the velocity trackers. Not that it has any effect,
> >0 + 0 is still 0...
> Not true, tp_filter_motion has:
> if (motion.dx != 0.0 || motion.dy != 0.0)
> filter_dispatch(tp->device->pointer.filter, &motion, tp, time);
> So the filter will not see the 0,0 event(s), I checked that before making this change.
> Any reason you did not review patch 1/3 ?
did review, forgot to send the email though, sorry. done now.
More information about the wayland-devel