[PATCH weston v2 6/7] text: Don't crash if a seat has no keyboard

Pekka Paalanen ppaalanen at gmail.com
Tue Dec 16 06:08:03 PST 2014


On Mon, 15 Dec 2014 21:22:11 +0000
Jan Arne Petersen <janarne at gmail.com> wrote:

> Hey,
> 
> On Mon Dec 08 2014 at 5:57:04 PM Derek Foreman <derekf at osg.samsung.com>
> wrote:
> 
> > A keyboard might not be present in a seat, so check that before
> > dereferencing keyboard related pointers.
> >
> > Also, use the keyboard pointer we set to shorten the code a little bit.
> >
> > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> > ---
> > Made the check similar to the dereference.
> >
> >  src/text-backend.c | 16 ++++++++++------
> >  1 file changed, 10 insertions(+), 6 deletions(-)
> >
> 
> Looks good.

Thanks for the reviews!

This pushed, thanks,
pq


More information about the wayland-devel mailing list