[PATCH weston] compositor-x11: Move the x11 event handler to the display loop

[Pekka Paalanen]

On Fri, 19 Dec 2014 08:08:33 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 19/12/14 06:40 AM, Pekka Paalanen wrote:
> > On Fri, 12 Dec 2014 14:29:42 -0600
> > Derek Foreman <derekf at osg.samsung.com> wrote:
> > 
> >> I just noticed that the follow patch *exactly* undoes commit 22ba60e
> >>
> >> Is there any other reason that commit was necessary, or was it intended
> >> to be cosmetic?
> > 
> > No, I don't think it was meant to be cosmetic.
> > 
> > There is some fancy input scheduling going on with the repaint loop, so
> > that input events would be sent as a burst to the clients when the
> > compositor is spinning in the repaint loop. The idea is that because
> > clients repaint only once per cycle, they don't need to be woken up due
> > to input any more often than that. Or that's how I understood it.
> > 
> > The problem here, I assume, is that the X11 fd is not only input, but
> > also output events, unlike DRM backend where the DRM fd is separate.
> > 
> > I would be inclined to just take this patch, because it fixes a bug and
> > the x11 backend is of lesser quality anyway.
> 
> Hmmm, I think the only event that matters is XCB_CLIENT_MESSAGE (delete
> window).  Can't I just handle that from an idle callback?

I suppose, but is it worth it? :-)


Thanks,
pq