[PATCH] libinput-seat: Don't regard no input devices as failure

Peter Hutterer peter.hutterer at who-t.net
Sun Dec 28 16:03:52 PST 2014


On Sun, Dec 28, 2014 at 11:25:16PM +0100, Sjoerd Simons wrote:
> The reason for not having any input devices could actually be that there
> are no input devices attached, imagine that. Mention that cause in the
> warning and no longer return an error.
> 
> This fixes starting weston on boards with no input devices attached.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons at collabora.co.uk>

Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

though I'd use "available" over "attached" which is less ambiguous in
a multi-seat scenario.

Cheers,
   Peter

> ---
>  src/libinput-seat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/libinput-seat.c b/src/libinput-seat.c
> index ef2d804..e8e872a 100644
> --- a/src/libinput-seat.c
> +++ b/src/libinput-seat.c
> @@ -241,11 +241,11 @@ udev_input_enable(struct udev_input *input)
>  		weston_log(
>  			"warning: no input devices on entering Weston. "
>  			"Possible causes:\n"
> +			"\t- no input devices are attached\n"
>  			"\t- no permissions to read /dev/input/event*\n"
>  			"\t- seats misconfigured "
>  			"(Weston backend option 'seat', "
>  			"udev device property ID_SEAT)\n");
> -		return -1;
>  	}
>  
>  	return 0;
> -- 
> 2.1.4
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> 


More information about the wayland-devel mailing list