[PATCH weston v2] Makefile.am: Fix protocol source files usage

[Jasper St. Pierre]

On Sun, Feb 2, 2014 at 1:06 AM, Kristian Høgsberg <hoegsberg at gmail.com>wrote:

> On Sat, Feb 01, 2014 at 09:39:12PM +0100, Quentin Glidic wrote:
> > From: Quentin Glidic <sardemff7+git at sardemff7.net>
> >
> > Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>
> > ---
> >
> > v2: Update .gitignore (Thanks Jasper)
>
> I looked into this and I did have generated .c and .h files in my source
> tree that made my out-of-tree builds succeed.  Also, I didn't find a good
> way to generate the .c and .h files in the build directories where they are
> used.  So let's go with this, now that we've explored alternative
> solutions.  I changed the path for generated files to just protocol/ - I
> don't want to get to deep paths and I don't see a problem in just having
> xml
> and C code side by side.  Also, the various -I$(top_srcdir)/protocol/src
> have to be $(top_builddir), but with that we're back to building again.
>
> As for make distcheck, that is now failing because we dist the generated
> C files, which end up in $(top_srcdir)/protocol/*.[ch], and with the change
> to pass -I$(top_builddir)/protocol, we don't see those file and we don't
> generate them because they're already in $(top_srcdir)/protocol.  I've
> fixed
> that in a follow-on commit, which marks all the generated files as
> nodist_*_SOURCE.
>

This sounds like it would break any srcdir != builddir build, like
gnome-continuous?


> Kristian
>
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>



-- 
  Jasper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20140202/d279b7bb/attachment-0001.html>