[PATCH weston v2] dim-layer: fix dimming for unfocused surfaces

Kristian Høgsberg hoegsberg at gmail.com
Wed Feb 5 17:27:29 PST 2014


On Thu, Jan 30, 2014 at 01:49:39PM +0100, pochu27 at gmail.com wrote:
> From: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>
> 
> Unfocusing a surface should dim it when dim-layer is enabled,
> but this got broken in commit 83ffd9.

Fix committed, thanks.

Kristian

> ---
>  desktop-shell/shell.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
> index 30bd273..3087042 100644
> --- a/desktop-shell/shell.c
> +++ b/desktop-shell/shell.c
> @@ -4250,14 +4250,14 @@ activate(struct desktop_shell *shell, struct weston_surface *es,
>  	else
>  		restore_all_output_modes(shell->compositor);
>  
> +	/* Update the surface’s layer. This brings it to the top of the stacking
> +	 * order as appropriate. */
> +	shell_surface_update_layer(shsurf);
> +
>  	if (shell->focus_animation_type != ANIMATION_NONE) {
>  		ws = get_current_workspace(shell);
>  		animate_focus_change(shell, ws, get_default_view(old_es), get_default_view(es));
>  	}
> -
> -	/* Update the surface’s layer. This brings it to the top of the stacking
> -	 * order as appropriate. */
> -	shell_surface_update_layer(shsurf);
>  }
>  
>  /* no-op func for checking black surface */
> -- 
> 1.8.5.3
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list