[PATCH 5/9] compositor: Output unplug in clone mode

Zhang, Xiong Y xiong.y.zhang at intel.com
Sun Feb 16 19:11:20 PST 2014

On Fri, 2014-02-14 at 09:56 +0200, Pekka Paalanen wrote:
> On Fri, 14 Feb 2014 15:17:40 +0800
> Xiong Zhang <xiong.y.zhang at intel.com> wrote:

> Hi,
> just a general note: it seems the DRM backend code is getting into
> pretty deep indentation levels. I would recommend splitting chunks out
> into functions where you have a logical does-one-thing block, even
> if the function would be only used in one place. It makes the code flow
> easier to read, when the blocks have been chosen properly and the
> resulting functions have descriptive names. Only if possible, of course.
Thanks for your recommendation. I will remember it and modify the code.

> Thanks,
> pq

More information about the wayland-devel mailing list